Code style checker, agent_check, and source-hygiene CI - #254
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 05196ce. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/code_style_check.pyfordocs/ezycad_code_style.mdrules clang-format does not enforce (vertical rhythm / blank lines first).scripts/agent_check.pyso agents and CI run ASCII + style in one Python process. Markdown table--checkruns when.mdpaths are given.ezycad_agent_checktarget.bool ok = false;over brace-init for clang-format=alignment.src/andtests/so the checker is clean.python scripts/agent_check.py.Closes #253
Related: #229
Test plan
python scripts/code_style_check.py src tests(no findings)ezycad_agent_checkandscripts/in the IDEpython scripts/agent_check.pyalso flags existing non-ASCII insrc/if any remain (e.g. pi).align_md_tables.py --checkis not in CI yet (several docs tables still unaligned).Note
Low Risk
Changes are mostly tooling, docs, and formatting; CI still enforces ASCII only, with no runtime or security-sensitive logic changes in the application.
Overview
Introduces
scripts/agent_check.pyas the single post-edit entry point: 7-bit ASCII onsrc/andtests/(default), optional Markdown table alignment when.mdpaths are passed, and optional--styleto run the new checker.scripts/code_style_check.pyenforces vertical rhythm blank-line rules fromdocs/ezycad_code_style.md(not CI).Source hygiene CI drops
check-nonascii-src.cmdin favor of Python 3.13 +PYTHONUTF8andpython scripts/agent_check.py. CMake adds anezycad_agent_checkIDE target and surfaces the scripts in the solution.Agent docs, local-dev, release, and the code style guide now point at
agent_check.py; the guide also prefers=initialization over brace-init so clang-format can align assignments.src/andtests/get widespread blank-line-only edits so the optional style checker is clean, plus a few ASCII comment fixes in tests (e.g.deg,pi).Reviewed by Cursor Bugbot for commit 3184300. Bugbot is set up for automated code reviews on this repo. Configure here.